presigned url 적용 #147
Merged
presigned url 적용 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msjang4
previously approved these changes
Nov 30, 2023
| @@ -15,7 +15,7 @@ export class AppController { | |||
| /** | |||
| * 광고 이미지 응답 | |||
| */ | |||
| @ApiTags('COMPLETE') | |||
| @ApiTags('LEGACY') | |||
There was a problem hiding this comment.
LEGACY 태그로 기존 코드 구분하신게 좋은거 같아요!
Comment on lines
+3
to
+4
| * 특정 광고 이미지의 presigned url만 받고 싶은 경우 | ||
| * @example 'test.webp' |
Comment on lines
45
to
51
| ( | ||
| await createPresignedUrl( | ||
| process.env.INPUT_BUCKET, | ||
| `${videoId}.${videoExtension}`, | ||
| 'PUT', | ||
| ) | ||
| ).url, |
There was a problem hiding this comment.
아래 코드는 어떠신가요?
createPresignedUrl(
process.env.INPUT_BUCKET,
`${videoId}.${videoExtension}`,
'PUT',
).then( data=> data.url)
server/src/ncpAPI/presignedURL.ts
Outdated
| new HttpRequest({ ...url, method }), | ||
| { expiresIn: 100 }, | ||
| ); | ||
| return { name: objectName, url: formatUrl(signedUrlObject) }; |
There was a problem hiding this comment.
url만 리턴하는게 자연스러울거 같은데 name을 같이 리턴해야만 하는 이유가 있을까요?
이 함수를 호출하는 코드에서도 url만 사용하는 경우가 있는 것 같아서요!
There was a problem hiding this comment.
광고 이미지를 재발급 받으려면 name이 필요한데 서비스에서 추가하기 귀찮아서 이렇게 했습니다..!
| ) | ||
| ).url | ||
| : null; | ||
| if (profileDto.profileExtension === '' && user.profileImageExtension) { |
There was a problem hiding this comment.
'profileImage' in profileDto 보다 직관적이네요 좋습니다
Comment on lines
+84
to
+86
| const result = ( | ||
| await this.UserModel.findOneAndUpdate({ uuid }, updateOption) | ||
| ).toObject(); |
There was a problem hiding this comment.
아마 toObject()를 lean:true로 대체할 수 잇을거같아요~
server/src/video/video.service.ts
Outdated
Comment on lines
80
to
81
| videoInfo.thumbnailExtension | ||
| ? ( |
There was a problem hiding this comment.
썸네일 확장자는 무조건 있을 거라 삼항연산이 필요 없을 거 같긴하네요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #146
작업 내용